-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21228] Improve CI workflows in main, and branching model refactor #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusPoderoso
force-pushed
the
feature/21228
branch
from
June 25, 2024 12:15
c20823c
to
44fbab6
Compare
JesusPoderoso
added
no-test
Skip CI tests if PR marked with this label
and removed
skip-ci
Automatically pass CI
labels
Jun 25, 2024
JesusPoderoso
force-pushed
the
feature/21228
branch
from
June 25, 2024 13:28
44fbab6
to
850cfc7
Compare
6 tasks
JesusPoderoso
force-pushed
the
feature/21228
branch
from
June 25, 2024 14:03
850cfc7
to
63cdfb3
Compare
This was referenced Jun 25, 2024
JesusPoderoso
force-pushed
the
feature/21228
branch
from
June 25, 2024 15:12
63cdfb3
to
73562d4
Compare
JesusPoderoso
force-pushed
the
feature/21228
branch
from
June 26, 2024 06:05
73562d4
to
c45099c
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
EduPonz
June 26, 2024 06:05
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…quired CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
feature/21228
branch
from
July 4, 2024 09:44
7a4dd6f
to
91e1d95
Compare
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
EduPonz
suggested changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
EduPonz
approved these changes
Jul 9, 2024
EduPonz
previously approved these changes
Jul 10, 2024
JesusPoderoso
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jul 10, 2024
JesusPoderoso
force-pushed
the
feature/21228
branch
from
July 11, 2024 14:06
d67ea98
to
4dc0fac
Compare
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
feature/21228
branch
from
July 11, 2024 14:07
4dc0fac
to
a80e8ae
Compare
EduPonz
approved these changes
Jul 11, 2024
EduPonz
pushed a commit
that referenced
this pull request
Jul 11, 2024
) * Refs #21228: Refactor Ubuntu CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Refactor Windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Remove previous workflow Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Add RELEASE_SUPPORT.md with Fast DDS references Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Fix windows CI removing win2017 Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Apply rev suggestions in main PR Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Avoid building dependencies again Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
Jul 11, 2024
) * Refs #21228: Refactor Ubuntu CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Refactor Windows CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Remove previous workflow Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Add RELEASE_SUPPORT.md with Fast DDS references Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Avoid running tests in 1.0.x Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Fix windows CI removing win2017 Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Deactivate Windows build temporary Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Apply rev suggestions in main PR Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Avoid building dependencies again Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21228: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the CI workflows, making them as similar as possible to the Fast DDS workflows.
It also introduces a braching model refactor, similiar as the performed in Fast DDS repository.
Backports to the supported branches will be manually opened:
Contributor Checklist
Reviewer Checklist